fix: fix deep sensitive redaction#43
Open
ccharly wants to merge 2 commits into
Open
Conversation
ccharly
force-pushed
the
cc/fix/fix-deep-sensitive
branch
from
d780b98 to
8d3c281
Compare
ccharly
force-pushed
the
cc/fix/fix-deep-sensitive
branch
from
8d3c281 to
94370f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ancestor branches were still able to keep a reference to the original data that was not redacted, resulting in potentially leaking the sensitive data using custom failure reporting.
Note
Medium Risk
Changes security-sensitive failure redaction logic; behavior is narrower and safer but must stay correct for all branch shapes (objects vs arrays).
Overview
Fixes a leak where validation failures on sibling fields of
sensitive()-wrapped objects could still expose secrets infailure.branchon outer branch entries.withRedactedBranchno longer only shallow-copies the immediate parent at the matching branch index. After redacting that parent, it walks up the branch and, for each ancestor object or array, finds the property/entry that still points at the original child (via===) and swaps in the already-sanitized child from the patched branch.New validation fixtures cover one-level and three-level nesting so root and intermediate ancestors show
***for sensitive keys when a nested sibling field fails.Reviewed by Cursor Bugbot for commit 5e9e9de. Bugbot is set up for automated code reviews on this repo. Configure here.